Persist QColorDialog custom color selections in ModOrganizer.ini#2396
Persist QColorDialog custom color selections in ModOrganizer.ini#2396JonathanFeenstra wants to merge 3 commits into
Conversation
139dfec to
6e825ef
Compare
Silarn
left a comment
There was a problem hiding this comment.
As far as I can tell, this is working.
|
Does this mean that people upgrading to latest MO2 will lose their color settings? If yes, is there a way to migrate? |
|
They seem to be stored in the Windows registry under |
|
Might be better to use MO2's upgrade functions to look for and import those settings if they are not defined in the local config. |
|
@JonathanFeenstra I would like to merge this but I think we should try importing the previous color settings. There should be an upgrade function when we detect a new MO2 version. I don't think it has to be handled by the installer. I also don't think we should delete those registry entries since each MO2 instance would have to save the color settings now. |
|
There's modorganizer/src/mainwindow.cpp Line 2197 in a329ce5 I'm assuming the next release version number will be 2.6.0. I tested that the Line 112 in a329ce5 |
|
I suppose we'll use 2.6. Testers can always drop their version number back to 2.5.2 in the mo.ini to test the upgrade process. Each instance tracks that separately. |
|
I think this looks fine. I'll include it in the beta but I suppose we'll need to test in the 2.6.0 RC. |
|
Should have noticed sooner and it would probably only be an issue for people running the betas, but we may want to only transfer the color settings if values haven't already been set (or are the default values). |
Custom colors selected in
QColorDialogused to be saved globally in Mod Organizer v2.5.2, but in Qt 6.11.0, this is no longer the case. As a result, they now reset every time after restarting the program.This PR fixes that by storing them in ModOrganizer.ini.